Skip to content

Conversation

rculbertson
Copy link
Contributor

Fix for issue where BigQueryImpl.testIamPermissions will throw a NullPointerException if the caller does not have any of the permissions being checked.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1595 ☕️

@rculbertson rculbertson requested review from a team and stephaniewang526 September 20, 2021 20:02
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Sep 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2021
@rculbertson rculbertson changed the title Fix for BigQueryImpl.testIamPermissions NPE fix: do not throw NPE from BigQueryImpl.testIamPermissions Sep 20, 2021
Fix for issue where BigQueryImpl.testIamPermissions will throw a NullPointerException if the caller does not have any of the permissions being checked.
@rculbertson rculbertson force-pushed the rculbertson/test-iam-permissions-npe branch from a7d8df7 to e5e72be Compare September 20, 2021 20:12
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 20, 2021
@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4251b19 into googleapis:master Sep 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 20, 2021
@rculbertson rculbertson deleted the rculbertson/test-iam-permissions-npe branch September 21, 2021 14:37
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement.

3 participants