Skip to content

Conversation

@stephaniewang526
Copy link
Contributor

Allow BigQuery client library users to define table-valued functions (TVFs) that return table data.

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label May 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2021
update license headers update license headers update license headers
@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #1278 (e9fc698) into master (f006fa9) will decrease coverage by 0.07%.
The diff coverage is 61.53%.

❗ Current head e9fc698 differs from pull request most recent head 6aac2ed. Consider uploading reports for the commit 6aac2ed to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@ ## master #1278 +/- ## ============================================ - Coverage 80.19% 80.12% -0.08%  - Complexity 1271 1277 +6  ============================================ Files 79 80 +1 Lines 6639 6665 +26 Branches 767 771 +4 ============================================ + Hits 5324 5340 +16  - Misses 917 923 +6  - Partials 398 402 +4 
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/google/cloud/bigquery/Routine.java 78.94% <0.00%> (-2.88%) 12.00 <0.00> (ø)
...in/java/com/google/cloud/bigquery/RoutineInfo.java 88.81% <40.00%> (-3.68%) 26.00 <1.00> (+1.00) ⬇️
...om/google/cloud/bigquery/StandardSQLTableType.java 85.71% <85.71%> (ø) 5.00 <5.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f006fa9...6aac2ed. Read the comment docs.

@stephaniewang526 stephaniewang526 marked this pull request as ready for review May 3, 2021 15:16
@stephaniewang526 stephaniewang526 requested a review from a team May 3, 2021 15:16
@stephaniewang526 stephaniewang526 requested a review from a team as a code owner May 3, 2021 15:16
@stephaniewang526 stephaniewang526 requested a review from shollyman May 3, 2021 15:16
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but seems like you should augment google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/RoutineTest.java to exercise the optional returnTableType so you retain coverage.

@stephaniewang526
Copy link
Contributor Author

Looks good, but seems like you should augment google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/RoutineTest.java to exercise the optional returnTableType so you retain coverage.

added additional test in RoutineTest

@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label May 4, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 89958e9 into googleapis:master May 4, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 4, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request May 11, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.129.0](https://www.github.com/googleapis/java-bigquery/compare/v1.128.3...v1.129.0) (2021-05-11) ### Features * add support for user defined TVFs ([#1278](https://www.github.com/googleapis/java-bigquery/issues/1278)) ([89958e9](https://www.github.com/googleapis/java-bigquery/commit/89958e9b5e4330b31878aa31b90569d2fd0310f2)) ### Dependencies * update dependency com.google.apis:google-api-services-bigquery to v2-rev20210422-1.31.0 ([#1275](https://www.github.com/googleapis/java-bigquery/issues/1275)) ([acc88c5](https://www.github.com/googleapis/java-bigquery/commit/acc88c5de445d166055825bf51d56a031e642675)) * update dependency com.google.apis:google-api-services-bigquery to v2-rev20210430-1.31.0 ([#1285](https://www.github.com/googleapis/java-bigquery/issues/1285)) ([e74ae1c](https://www.github.com/googleapis/java-bigquery/commit/e74ae1c180c8ce27c9c8985c1935a894889b6375)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v1.1.0 ([#1290](https://www.github.com/googleapis/java-bigquery/issues/1290)) ([e60f2cd](https://www.github.com/googleapis/java-bigquery/commit/e60f2cd823b1551e43154f87a5157acca51b346c)) * update jmh.version to v1.30 ([#1281](https://www.github.com/googleapis/java-bigquery/issues/1281)) ([3704a6c](https://www.github.com/googleapis/java-bigquery/commit/3704a6cc46b84ce3b5ba01466ba39333f1b16886)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-owl-bot bot added a commit that referenced this pull request Nov 9, 2021
java-format requires JRE v11+ to run linter. It still check older code, just jre has to be 11+: google/google-java-format#529 Updating ci.yaml template since it is applicable for all the libraries. Source-Link: googleapis/synthtool@42a3786 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:14ecf64ec36f67c7bf04e3dc0f68eafcc01df3955121c38862b695e2ae7515d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement.

2 participants