Skip to content

feat: sample - add col load append #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 22, 2020
Merged

feat: sample - add col load append #112

merged 10 commits into from
Jan 22, 2020

Conversation

stephaniewang526
Copy link
Contributor

Fixes b/147690070
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2020
@codecov
Copy link

codecov bot commented Jan 16, 2020 •
edited
Loading

Codecov Report

Merging #112 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #112 +/- ## ============================================ + Coverage 77.32% 77.38% +0.05%  - Complexity 1108 1110 +2  ============================================ Files 73 73 Lines 5915 5916 +1 Branches 645 645 ============================================ + Hits 4574 4578 +4  + Misses 1014 1013 -1  + Partials 327 325 -2
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 5.2% <0%> (-0.02%) 2% <0%> (ø)
...google/cloud/bigquery/StandardTableDefinition.java 92.64% <0%> (+5.88%) 16% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eedb54...02e5370. Read the comment docs.
kurtisvg
kurtisvg approved these changes Jan 17, 2020
View reviewed changes
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2020
kurtisvg
kurtisvg suggested changes Jan 21, 2020
View reviewed changes
kurtisvg
kurtisvg suggested changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments on checked vs unchecked.
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2020
kurtisvg
kurtisvg approved these changes Jan 22, 2020
View reviewed changes
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2020
@stephaniewang526 stephaniewang526 merged commit 833b953 into googleapis:master Jan 22, 2020
@stephaniewang526 stephaniewang526 deleted the add-col-load-append branch January 22, 2020 17:18
@yoshi-automation yoshi-automation mentioned this pull request Jan 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

5 participants

@stephaniewang526 @kurtisvg @googlebot @pmakani @yoshi-kokoro