This repository was archived by the owner on Sep 9, 2023. It is now read-only.
feat: adds ValueConverter utility and demo samples #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added the samples 
google-cla bot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #108 +/- ## ============================================= - Coverage 76.57% 64.57% -12.00% + Complexity 606 530 -76 ============================================= Files 48 49 +1 Lines 5617 3263 -2354 Branches 69 14 -55 ============================================= - Hits 4301 2107 -2194 + Misses 1227 1077 -150 + Partials 89 79 -10 Continue to review full report at Codecov.
|
chingor13 suggested changes Dec 14, 2020
...oud-aiplatform/src/main/java/com/google/cloud/aiplatform/v1beta1/utility/ValueConverter.java Outdated Show resolved Hide resolved
...oud-aiplatform/src/main/java/com/google/cloud/aiplatform/v1beta1/utility/ValueConverter.java Outdated Show resolved Hide resolved
...e-cloud-aiplatform/src/test/java/com/google/cloud/aiplatform/utility/ValueConverterTest.java Outdated Show resolved Hide resolved
...e-cloud-aiplatform/src/test/java/com/google/cloud/aiplatform/utility/ValueConverterTest.java Outdated Show resolved Hide resolved
...e-cloud-aiplatform/src/test/java/com/google/cloud/aiplatform/utility/ValueConverterTest.java Outdated Show resolved Hide resolved
...e-cloud-aiplatform/src/test/java/com/google/cloud/aiplatform/utility/ValueConverterTest.java Outdated Show resolved Hide resolved
| Warning: This pull request is touching the following templated files:
|
chingor13 suggested changes Dec 17, 2020
...e-cloud-aiplatform/src/test/java/com/google/cloud/aiplatform/utility/ValueConverterTest.java Outdated Show resolved Hide resolved
| * limitations under the License. | ||
| */ | ||
| | ||
| package com.google.cloud.aiplatform.utility; |
There was a problem hiding this comment.
nit: most other utility packages use util
Comment on lines 74 to 78
| if (key.contains("multiLabel")) { | ||
| actualBoolValueEntry = entry; | ||
| } else if (key.contains("modelType")) { | ||
| actualStringValueEntry = entry; | ||
| } else if (key.contains("budgetMilliNodeHours")) { |
There was a problem hiding this comment.
should these checks for key name use equals?
| } | ||
| | ||
| Value actualBoolValue = (Value) actualBoolValueEntry.getValue(); | ||
| Assert.assertEquals(testObjectInputs.getMultiLabel(), actualBoolValue.getBoolValue()); |
There was a problem hiding this comment.
nit: usually Assert.assertEquals is statically imported
| private static AutoMlImageClassificationInputs testObjectInputs; | ||
| | ||
| @Before | ||
| public void setUp() throws InvalidProtocolBufferException { |
There was a problem hiding this comment.
Everything in this setup is only used in the one test - you can move it inside there.
google-cloud-aiplatform/src/test/java/com/google/cloud/aiplatform/util/ValueConverterTest.java Outdated Show resolved Hide resolved
…orm/util/ValueConverterTest.java Co-authored-by: yoshi-code-bot <70984784+yoshi-code-bot@users.noreply.github.com>
chingor13 approved these changes Dec 18, 2020
dizcology approved these changes Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
ValueConverterclass, that provides methods for convertingMessagetypes to/fromprotobuf.ValueobjectsValueConverterclass