Fix compilation for Java 10 #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
chingor13 commented Aug 24, 2018
chingor13 commented - Update datanucleus plugin versions to build on Java 9/10.
- Update clirr-maven-plugin to 2.8 to work on Java 10.
- Removing Java 9 from the test matrix as we cannot resolve the issue and guava does not seem to work on Java 9 anyways.
| The Java 9 test was removed internally and should not run on future PRs. |
jeanbza suggested changes Aug 27, 2018
| @jadekler The only versions that changed were the maven plugins which aren't included in the assembly - they only are used during the development and build process. |
This was referenced Oct 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.