BigQuery: Add support of the project ID with org prefix to the Table.from_string() method #9161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* '_parse_id' method renamed to '_split_id' * switched to 're.groups' implementation instead of partly grouping
googlebot added the cla: yes 
IlyaFaer added api: bigquery 
yoshi-kokoro removed the kokoro:force-run flake8 fixed
IlyaFaer added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
plamut reviewed Sep 3, 2019
Contributor
plamut left a comment
plamut left a comment There was a problem hiding this comment.
The PR fixes the reported issue. 👍
There is one docstring missing, and the regex pattern might need a change, please check the comment if it applies.
BTW, it would probably be useful to add another test case for tables with an optional partition suffix, e.g. "example.com:project_id.dataset_id.table_id$20190903"
.
* added the docstring for the '_split_id' method
plamut approved these changes Sep 5, 2019
Contributor
plamut left a comment
plamut left a comment There was a problem hiding this comment.
Under the assumption that we do not want to handle all possible cases such as too long ID parts, etc., these changes look good to me. 👍
IlyaFaer added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run IlyaFaer added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
tswast approved these changes Sep 6, 2019
emar-kar deleted the project-ID-w-prefix-for-the-Table.from_string-method branch emar-kar added a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 11, 2019
…from_string() method (googleapis#9161) * add prefix support * Update _helpers.py * consolidate the regex * update split_id method * '_parse_id' method renamed to '_split_id' * switched to 're.groups' implementation instead of partly grouping * Update dataset.py flake8 fixed * Update _helpers.py * added the docstring for the '_split_id' method * fix lint failure
emar-kar added a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
…from_string() method (googleapis#9161) * add prefix support * Update _helpers.py * consolidate the regex * update split_id method * '_parse_id' method renamed to '_split_id' * switched to 're.groups' implementation instead of partly grouping * Update dataset.py flake8 fixed * Update _helpers.py * added the docstring for the '_split_id' method * fix lint failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
ID splitting was moved to a separate method to avoid code duplication.
Datasetfile changed to the new implementation.Closes: #7827