Skip to content

Raise with extra or missing columns in load_table_from_dataframe schema. #9096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
plamut merged 1 commit into from
Aug 26, 2019
Merged

Raise with extra or missing columns in load_table_from_dataframe schema. #9096

plamut merged 1 commit into from
Aug 26, 2019

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Aug 24, 2019

I found it to be difficult to debug typos in column/index names in the
schema, so I have hardened the error messages to indicate when unknown
field values are found.

Split from #9084
Follow-up to #8140
@tswast
Raise with extra or missing columns in load_table_from_dataframe sc…
dd96769 
…hema. I found it to be difficult to debug typos in column/index names in the schema, so I have hardened the error messages to indicate when unknown field values are found.
@tswast tswast added the api: bigquery Issues related to the BigQuery API. label Aug 24, 2019
@tswast tswast requested review from a team and plamut August 24, 2019 00:15
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2019
@tswast tswast mentioned this pull request Aug 24, 2019
Closed
plamut
plamut reviewed Aug 26, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it's just the snippets tests failing. Will try to re-run them.

Edit: It was apparently flakiness, as changes in this PR are quite benign.
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2019
@plamut plamut merged commit cdb4cc4 into googleapis:master Aug 26, 2019
@tswast tswast deleted the issue8140-schema-mismatch branch August 26, 2019 17:50
@tswast
Copy link
Contributor Author

tswast commented Aug 26, 2019

Thanks Peter. Next time we get a flake, let's file an issue. Seems like we've been having more test flakes lately.
HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull request Aug 29, 2019
@tswast @plamut
Raise with extra or missing columns in load_table_from_dataframe sc…
ac1beab 
…hema. (googleapis#9096) I found it to be difficult to debug typos in column/index names in the schema, so I have hardened the error messages to indicate when unknown field values are found.
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@tswast @emar-kar
Raise with extra or missing columns in load_table_from_dataframe sc…
2b93668 
…hema. (googleapis#9096) I found it to be difficult to debug typos in column/index names in the schema, so I have hardened the error messages to indicate when unknown field values are found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

4 participants

@tswast @plamut @googlebot @yoshi-kokoro