Skip to content

Conversation

@yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/synth.py. synthtool > Ensuring dependencies. synthtool > Pulling artman image. latest: Pulling from googleapis/artman Digest: sha256:63f21e83cb92680b7001dc381069e962c9e6dee314fd8365ac554c07c89221fb Status: Image is up to date for googleapis/artman:latest synthtool > Cloning googleapis. synthtool > Running generator for google/cloud/bigquery/datatransfer/artman_bigquerydatatransfer.yaml. synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerydatatransfer-v1. synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/bigquery/datatransfer/v1/transfer.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerydatatransfer-v1/google/cloud/bigquery_datatransfer_v1/proto/transfer.proto synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/bigquery/datatransfer/v1/datasource.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerydatatransfer-v1/google/cloud/bigquery_datatransfer_v1/proto/datasource.proto synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/bigquery/datatransfer/v1/datatransfer.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerydatatransfer-v1/google/cloud/bigquery_datatransfer_v1/proto/datatransfer.proto synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerydatatransfer-v1/google/cloud/bigquery_datatransfer_v1/proto. synthtool > Replaced 'from google.cloud.bigquery.datatransfer_v1.proto' in google/cloud/bigquery_datatransfer_v1/proto/datatransfer_pb2.py. synthtool > Replaced 'from google.cloud.bigquery.datatransfer_v1.proto' in google/cloud/bigquery_datatransfer_v1/proto/datatransfer_pb2_grpc.py. synthtool > Replaced 'google-cloud-bigquerydatatransfer' in google/cloud/bigquery_datatransfer_v1/gapic/data_transfer_service_client.py. synthtool > Replaced 'import google.api_core.gapic_v1.method\n' in google/cloud/bigquery_datatransfer_v1/gapic/data_transfer_service_client.py. .coveragerc .flake8 MANIFEST.in noxfile.py.j2 setup.cfg Running session blacken Creating virtualenv using python3.6 in .nox/blacken pip install black==19.3b0 black docs google tests noxfile.py setup.py samples reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/__init__.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/__init__.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/__init__.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/gapic/enums.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/gapic/transports/data_transfer_service_grpc_transport.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/gapic/data_transfer_service_client_config.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/proto/datasource_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/proto/datatransfer_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/gapic/data_transfer_service_client.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/proto/transfer_pb2_grpc.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/types.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/noxfile.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/tests/system/gapic/v1/test_system_data_transfer_service_v1.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/proto/transfer_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/tests/unit/gapic/v1/test_data_transfer_service_client_v1.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/proto/datasource_pb2.py reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/proto/datatransfer_pb2.py All done! ✨ 🍰 ✨ 18 files reformatted, 9 files left unchanged. Session blacken was successful. synthtool > Cleaned up 2 temporary directories. synthtool > Wrote metadata to synth.metadata. 
@yoshi-automation yoshi-automation requested a review from a team July 10, 2019 12:13
@yoshi-automation yoshi-automation added the api: bigquerydatatransfer Issues related to the BigQuery Data Transfer Service API. label Jul 10, 2019
@yoshi-automation yoshi-automation force-pushed the autosynth-bigquery_datatransfer branch from e396b27 to 6259eee Compare July 10, 2019 12:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2019
@tseaver tseaver changed the title [CHANGE ME] Re-generated bigquery_datatransfer to pick up changes in the API or client library generator. BigQuery Datatransfer: Add 'DatasourceServiceClient'; add 'start_manual_transfer_runs' method; add 'client_info'/'version_info' support; allow passing kwargs to 'create_channel'; add path helpers (via synth). Jul 10, 2019
@tswast
Copy link
Contributor

tswast commented Jul 15, 2019

Thanks @tseaver

Looks like the unit and system tests are passing. What should we do about the cover failures?

@tseaver
Copy link
Contributor

tseaver commented Jul 16, 2019

@tswast I would prefer that we add tests for the "stub" module, likely via autogen. E.g.:

# tests/unit/test_him.py def test_shim(): from google.cloud import bigquery_datatransfer from google.cloud import bigquery_datatransfer_v1 assert bigquery_datatransfer.__all__ == bigquery_datatransfer_v1.__all__ for name in bigquery_datatransfer.__all__: found = getattr(bigquery_datatransfer, name) expected = getattr(bigquery_datatransfer_v1, name) assert found is expected
@tswast
Copy link
Contributor

tswast commented Jul 16, 2019

Thanks @tseaver. I pushed a commit with this as a manual test. I've filed https://github.com/googleapis/gapic-generator/issues/2876 for the gapic generator to add such a test.

@tswast tswast merged commit 17fc24a into master Jul 17, 2019
parthea pushed a commit that referenced this pull request Sep 22, 2023
…d; add `client_info`/`version_info` support; allow passing kwargs to `create_channel`; add path helpers (via synth). (#8630) * Add `DatasourceServiceClient`; add `start_manual_transfer_runs` method; add `client_info`/`version_info` support; allow passing kwargs to `create_channel`; add path helpers (via synth). * Add manual unit test for versionless import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerydatatransfer Issues related to the BigQuery Data Transfer Service API. cla: yes This human has signed the Contributor License Agreement. codegen

5 participants