Skip to content

Conversation

@MartinNowak
Copy link
Contributor

  • currently limited to 4MiB
  • compare to f636c8d which does the same for the monitoring API
- currently limited to 4MiB - compare to googleapis@f636c8d which does the same for the monitoring API
@MartinNowak MartinNowak requested a review from crwilcox as a code owner April 5, 2019 07:40
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 5, 2019
@tswast
Copy link
Contributor

tswast commented Apr 5, 2019

@crwilcox Could you review this? Seems okay once @MartinNowak signs the CLA, but I don't know if synthtool is just going to overwrite it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 8, 2019
@MartinNowak MartinNowak requested a review from a team April 8, 2019 21:19
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @MartinNowak. FYI: I've added this to synth.py as well so that the code generator doesn't override your changes.

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2019
@tswast tswast merged commit 5ad5bee into googleapis:master Apr 8, 2019
parthea pushed a commit that referenced this pull request Aug 21, 2025
* remove gRPC size limit for bigquery storage - currently limited to 4MiB - compare to f636c8d which does the same for the monitoring API * Add override to synth config.
parthea pushed a commit that referenced this pull request Sep 16, 2025
* remove gRPC size limit for bigquery storage - currently limited to 4MiB - compare to f636c8d which does the same for the monitoring API * Add override to synth config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

4 participants