Skip to content

Add heartbeating to the streaming pull manager #5413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2018
Merged

Add heartbeating to the streaming pull manager #5413

merged 2 commits into from
May 30, 2018

Conversation

@theacodes
Copy link
Contributor

No description provided.

@theacodes theacodes requested a review from crwilcox May 30, 2018 17:59
@theacodes theacodes requested a review from lukesneeringer as a code owner May 30, 2018 17:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 30, 2018
crwilcox
crwilcox approved these changes May 30, 2018
View reviewed changes
pubsub/google/cloud/pubsub_v1/subscriber/_protocol/heartbeater.py

_LOGGER = logging.getLogger(__name__)
_HEARTBEAT_WORKER_NAME = 'Thread-Heartbeater'
_DEFAULT_PERIOD = 30

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

pubsub/google/cloud/pubsub_v1/subscriber/_protocol/heartbeater.py

def stop(self):
with self._operational_lock:
self._stop_event.set()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes theacodes merged commit 7d2138a into googleapis:master May 30, 2018
@theacodes theacodes deleted the pubsub-heartbeat branch May 30, 2018 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants

@theacodes @crwilcox @googlebot