Add vision label detection #2237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
daspecster added do not merge 
googlebot added the cla: yes daspecster force-pushed the vision-label-detection branch 2 times, most recently from 8395fa7 to c49f0c2 Compare Merged
daspecster force-pushed the vision-label-detection branch from c49f0c2 to 8669d3a Compare daspecster removed the do not merge | @tseaver LMKWYT! |
google/cloud/vision/entity.py Outdated
| bounds = Bounds.from_api_repr(response['boundingPoly']) | ||
| bounds = [] | ||
| if 'boundingPoly' in response: | ||
| bounds = Bounds.from_api_repr(response['boundingPoly']) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver reviewed Sep 14, 2016
google/cloud/vision/entity.py Outdated
| bounds = [] | ||
| if 'boundingPoly' in response: | ||
| bounds = Bounds.from_api_repr(response['boundingPoly']) | ||
| bounds = Bounds.from_api_repr(response.get('boundingPoly', {})) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| vertices.append(Vertex(vertex.get('x', None), | ||
| vertex.get('y', None))) | ||
| vertices = [Vertex(vertex.get('x', None), vertex.get('y', None)) for | ||
| vertex in response_vertices.get('vertices', [])] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
daspecster force-pushed the vision-label-detection branch from c71fa03 to f75f96d Compare | @tseaver anything else? |
| LGTM pending Travis. |
daspecster force-pushed the vision-label-detection branch from f75f96d to 408f929 Compare | Squashed...going to wait for travis one more time. |
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Based off of #2236.
I was able to DRY up the requests code for the
EntityAnnotationbased detection types.✅ Waiting for #2236 before rebasing.