Shorten custom metric type used for system testing. #2213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When run on Travis, the 'unique_resource_id()' function causes the type name to exceed 40 characters: reducing the prefix length empirically allows the 'create()' | 'delete()' pair to work as intended.
googlebot added the cla: yes 
| OK a 500 was totally the wrong error. LGTM |
| The conversation above could give the mistaken impression that the limit imposed by the API on the length of metric type names is 40 characters, so I'd just like to clarify that the limit is supposed to be 100 characters. |
| Similarly, the 500 gives the mistaken impression that the error is transient. |
| Why would a 500 give the impression that the error is transient? |
| "500 Internal Server Error" indicates the backend failed to handle the request. I guess as a user I just assume a Google API won't fail to handle the same valid request on a consistent basis. |
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When run on Travis, the
unique_resource_id()function causes the type name to exceed 40 characters: reducing the prefix length empirically allows thecreate()|delete()pair to work as intended.Towards #2176.