Skip to content

Retry on 500 from 'descriptor.{create,delete}'. #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2016
Merged

Retry on 500 from 'descriptor.{create,delete}'. #2197

merged 1 commit into from
Aug 25, 2016

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 25, 2016

Toward #2176.
@tseaver tseaver added api: monitoring Issues related to the Cloud Monitoring API. flaky labels Aug 25, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2016
dhermes
dhermes reviewed Aug 25, 2016
View reviewed changes
system_tests/monitoring.py Outdated
from system_test_utils import unique_resource_id

retry_404 = RetryErrors(NotFound)
retry_404_500 = RetryErrors(NotFound, InternalServerError)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver changed the title Retry on 500 from 'descriptor.delete'. Retry on 500 from 'descriptor.{create,delete}'. Aug 25, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Aug 25, 2016

@dhermes I just updated the commit to wrap a retry_500 around the descriptor.create. PTAL
@daspecster
Copy link
Contributor

daspecster commented Aug 25, 2016

LGTM, although I don't get why it's ok to throw a 500.
Is there a way that we can remember to undo this once the upstream service starts becoming more reliable?
@tseaver
Copy link
Contributor Author

tseaver commented Aug 25, 2016

@daspecster How will we ever know: that is a "Schroedinger's Cat" problem.
@tseaver tseaver merged commit 5896dd3 into googleapis:master Aug 25, 2016
@tseaver tseaver deleted the 2176-monitoring-500-on-descriptor-delete branch August 25, 2016 21:21
@tseaver tseaver mentioned this pull request Aug 26, 2016
Merged
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement.

4 participants

@tseaver @daspecster @dhermes @googlebot