Returning ints from BigQuery Table.num_rows/num_bytes. #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
googlebot added the cla: yes 
| Do we need to add / update tests exercising the |
| Good call. I was peeling off my notes robotically and it didn't occur to me. |
Also fixing Table.expires docstring typo.
dhermes force-pushed the bigquery-int-values branch from b87d566 to 5c253ec Compare | @tseaver Rebased and added two tests. They are a bit over-loaded: in reality they each contain 4 itty bitty tests. |
| LGTM |
dhermes added a commit that referenced this pull request Dec 1, 2015
Returning ints from BigQuery Table.num_rows/num_bytes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Also fixing
Table.expiresdocstring typo.