Skip to content

#1071: fix BQ system tests under Py3k #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2015
Merged

#1071: fix BQ system tests under Py3k #1074

merged 2 commits into from
Aug 19, 2015

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 19, 2015

See #1071.
tseaver added 2 commits August 19, 2015 09:42
@tseaver
Open CSV tempfile in text mode.
8986b98 
Prevents TypeError in 'writerow()' on Py3k. Fixes #1071.
@tseaver
Defer adding CSV blob to 'to_delete' until after upload succeeds.
2ba2424 
Avoids blowing up the cleanup code, stranding the bucket.
@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: bigquery Issues related to the BigQuery API. labels Aug 19, 2015
@tseaver
Copy link
Contributor Author

tseaver commented Aug 19, 2015

@dhermes PTAL.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2015
@dhermes
Copy link
Contributor

dhermes commented Aug 19, 2015

Makes me think we should also have tearDown keep going if a delete fails. (Better yet would be just to leave blobs out of it and call bucket.delete(force=True), though then it can't inter-mix with the delete-able BigQuery objects.)
@dhermes
Copy link
Contributor

dhermes commented Aug 19, 2015

@tseaver Running system tests now on local machine. Should be done soon.
@tseaver
Copy link
Contributor Author

tseaver commented Aug 19, 2015

We could make to_delete a list of callables, and use functools.partial to curry in the force=True bit for buckets.
@tseaver
Copy link
Contributor Author

tseaver commented Aug 19, 2015

BTW, do you have access to clean up the stranded buckets on the Travis project's console?
@dhermes
Copy link
Contributor

dhermes commented Aug 19, 2015

Yes I do. Just deleted the 2 most recent from test failures
@dhermes
Copy link
Contributor

dhermes commented Aug 19, 2015

LGTM. System tests all passing.
dhermes added a commit that referenced this pull request Aug 19, 2015
@dhermes
Merge pull request #1074 from tseaver/1071-bigquery-system_tests_py3k
c2370a8 
#1071: fix BQ system tests under Py3k
@dhermes dhermes merged commit c2370a8 into googleapis:master Aug 19, 2015
@tseaver tseaver deleted the 1071-bigquery-system_tests_py3k branch August 19, 2015 14:20
@dhermes dhermes mentioned this pull request Sep 30, 2015
Merged
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
KMS: Clean up base64 logic in the encrypt and decrypt functions. [(#1074
f65c467 
)](GoogleCloudPlatform/python-docs-samples#1074) The use of base64 is essentially an implementation detail of the Cloud KMS REST API: it is required only so that arbitrary binary data can be included in a JSON string, which only allows Unicode characters. Therefore, the "encrypt" sample function should decode the base64-encoded ciphertext before writing the file. Similarly, "decrypt" should not assume that an input file is base64-encoded, but should perform the base64-encoding itself before sending the encrypted data to KMS. This aligns with how the "gcloud kms encrypt" and "gcloud kms decrypt" commands behave. See https://stackoverflow.com/q/45699472 for an example of user confusion caused by the mismatch.
gcf-owl-bot bot added a commit that referenced this pull request Aug 1, 2025
@gcf-owl-bot
feat: Update Compute Engine v1 API to revision 20250717 (#1074)
1f40057 
Source-Link: googleapis/googleapis@6764f0e Source-Link: googleapis/googleapis-gen@6c2b3c1 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjZjMmIzYzFkNTM0YWI2MWIzYWQxMTkwMGU0ZmVhYTc5M2I1NTYyMjMifQ==
ohmayr pushed a commit that referenced this pull request Aug 5, 2025
@gcf-owl-bot
feat: [google-cloud-compute] Update Compute Engine v1 API to revision…
0c26f13 
… 20250717 (#1074) (#14169) - [ ] Regenerate this pull request now. Source-Link: googleapis/googleapis@6764f0e Source-Link: googleapis/googleapis-gen@6c2b3c1 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjZjMmIzYzFkNTM0YWI2MWIzYWQxMTkwMGU0ZmVhYTc5M2I1NTYyMjMifQ== --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@release-please release-please bot mentioned this pull request Aug 5, 2025
Merged
parthea pushed a commit that referenced this pull request Aug 6, 2025
@release-please
chore: release main (#14179)
60a1070 
🤖 I have created a release *beep* *boop* --- <details><summary>google-apps-chat: 0.2.8</summary> ## [0.2.8](google-apps-chat-v0.2.7...google-apps-chat-v0.2.8) (2025-08-06) ### Features * Addition of app auth support for chat api ([e9795e3](e9795e3)) ### Documentation * Update reference documentation for createSpace,updateSpace,deleteSpace,createMembership,updateMembership,deleteMembership and the newly added field -customer- in space.proto ([e9795e3](e9795e3)) </details> <details><summary>google-cloud-compute: 1.34.0</summary> ## [1.34.0](google-cloud-compute-v1.33.0...google-cloud-compute-v1.34.0) (2025-08-06) ### Features * [google-cloud-compute] Update Compute Engine v1 API to revision 20250717 ([#1074](#1074)) ([#14169](#14169)) ([0c26f13](0c26f13)) </details> <details><summary>google-cloud-compute-v1beta: 0.1.5</summary> ## [0.1.5](google-cloud-compute-v1beta-v0.1.4...google-cloud-compute-v1beta-v0.1.5) (2025-08-06) ### Features * [google-cloud-compute-v1beta] Update Compute Engine v1beta API to revision 20250717 ([#14170](#14170)) ([2fd889a](2fd889a)) </details> <details><summary>google-cloud-config: 0.1.20</summary> ## [0.1.20](google-cloud-config-v0.1.19...google-cloud-config-v0.1.20) (2025-08-06) ### Features * add a FooBar API ([2f16fa5](2f16fa5)) * add the VeoTuningSpec ([2f16fa5](2f16fa5)) * Remove private preview label from Model Armor protos ([2f16fa5](2f16fa5)) ### Documentation * update comments for rpc BatchCreatePullRequestComments, ResolvePullRequestComments and UnresolvePullRequestComments ([2f16fa5](2f16fa5)) </details> <details><summary>google-cloud-configdelivery: 0.1.3</summary> ## [0.1.3](google-cloud-configdelivery-v0.1.2...google-cloud-configdelivery-v0.1.3) (2025-08-06) ### Documentation * Mark Variant's resources field as input only ([477c835](477c835)) </details> <details><summary>google-cloud-dataproc-metastore: 1.19.0</summary> ## [1.19.0](google-cloud-dataproc-metastore-v1.18.3...google-cloud-dataproc-metastore-v1.19.0) (2025-08-06) ### Features * add a FooBar API ([2f16fa5](2f16fa5)) * add the VeoTuningSpec ([2f16fa5](2f16fa5)) * Remove private preview label from Model Armor protos ([2f16fa5](2f16fa5)) ### Documentation * update comments for rpc BatchCreatePullRequestComments, ResolvePullRequestComments and UnresolvePullRequestComments ([2f16fa5](2f16fa5)) </details> <details><summary>google-cloud-modelarmor: 0.2.8</summary> ## [0.2.8](google-cloud-modelarmor-v0.2.7...google-cloud-modelarmor-v0.2.8) (2025-08-06) ### Features * MultiLanguage Detection in Model Armor Floor Setting ([30452f1](30452f1)) * MultiLanguage Detection in Model Armor Floor Setting ([30452f1](30452f1)) </details> <details><summary>google-cloud-privilegedaccessmanager: 0.1.9</summary> ## [0.1.9](google-cloud-privilegedaccessmanager-v0.1.8...google-cloud-privilegedaccessmanager-v0.1.9) (2025-08-06) ### Features * [google-cloud-privilegedaccessmanager] Introducing new Grant states for Withdrawal operation ([#14168](#14168)) ([e35550f](e35550f)) * add a FooBar API ([2f16fa5](2f16fa5)) * add the VeoTuningSpec ([2f16fa5](2f16fa5)) * Remove private preview label from Model Armor protos ([2f16fa5](2f16fa5)) ### Documentation * update comments for rpc BatchCreatePullRequestComments, ResolvePullRequestComments and UnresolvePullRequestComments ([2f16fa5](2f16fa5)) </details> <details><summary>google-cloud-securesourcemanager: 0.1.17</summary> ## [0.1.17](google-cloud-securesourcemanager-v0.1.16...google-cloud-securesourcemanager-v0.1.17) (2025-08-06) ### Features * add a FooBar API ([2f16fa5](2f16fa5)) * add the VeoTuningSpec ([2f16fa5](2f16fa5)) * Remove private preview label from Model Armor protos ([2f16fa5](2f16fa5)) ### Documentation * update comments for rpc BatchCreatePullRequestComments, ResolvePullRequestComments and UnresolvePullRequestComments ([2f16fa5](2f16fa5)) </details> <details><summary>google-shopping-merchant-accounts: 0.3.6</summary> ## [0.3.6](google-shopping-merchant-accounts-v0.3.5...google-shopping-merchant-accounts-v0.3.6) (2025-08-06) ### Features * [google-shopping-merchant-accounts] add accounts API client libraries for v1 ([#14187](#14187)) ([df0012e](df0012e)) </details> <details><summary>google-shopping-merchant-conversions: 0.1.10</summary> ## [0.1.10](google-shopping-merchant-conversions-v0.1.9...google-shopping-merchant-conversions-v0.1.10) (2025-08-06) ### Features * add conversions API client libraries for v1 ([f2d8f3e](f2d8f3e)) * add conversions API client libraries for v1 ([#14175](#14175)) ([f2d8f3e](f2d8f3e)) </details> <details><summary>google-shopping-merchant-datasources: 0.1.11</summary> ## [0.1.11](google-shopping-merchant-datasources-v0.1.10...google-shopping-merchant-datasources-v0.1.11) (2025-08-06) ### Features * [google-shopping-merchant-datasources] add datasources API client libraries for v1 ([#14174](#14174)) ([147cca6](147cca6)) </details> <details><summary>google-shopping-merchant-inventories: 0.1.16</summary> ## [0.1.16](google-shopping-merchant-inventories-v0.1.15...google-shopping-merchant-inventories-v0.1.16) (2025-08-06) ### Features * [google-shopping-merchant-inventories] add inventories API client libraries for v1 ([#14172](#14172)) ([3e038db](3e038db)) </details> <details><summary>google-shopping-merchant-issueresolution: 0.1.1</summary> ## [0.1.1](google-shopping-merchant-issueresolution-v0.1.0...google-shopping-merchant-issueresolution-v0.1.1) (2025-08-06) ### Features * [google-shopping-merchant-issueresolution] add issueresolution API client libraries for v1 ([#14178](#14178)) ([234135f](234135f)) </details> <details><summary>google-shopping-merchant-lfp: 0.1.11</summary> ## [0.1.11](google-shopping-merchant-lfp-v0.1.10...google-shopping-merchant-lfp-v0.1.11) (2025-08-06) ### Features * [google-shopping-merchant-lfp] add lfp API for v1 ([#14176](#14176)) ([4181153](4181153)) </details> <details><summary>google-shopping-merchant-notifications: 0.1.9</summary> ## [0.1.9](google-shopping-merchant-notifications-v0.1.8...google-shopping-merchant-notifications-v0.1.9) (2025-08-06) ### Features * add notifications API client libraries for v1 ([9462b82](9462b82)) * add notifications API client libraries for v1 ([#14173](#14173)) ([9462b82](9462b82)) </details> <details><summary>google-shopping-merchant-ordertracking: 0.1.1</summary> ## [0.1.1](google-shopping-merchant-ordertracking-v0.1.0...google-shopping-merchant-ordertracking-v0.1.1) (2025-08-06) ### Features * [google-shopping-merchant-ordertracking] add ordertracking API client libraries for v1 ([#14184](#14184)) ([299698d](299698d)) </details> <details><summary>google-shopping-merchant-products: 0.2.7</summary> ## [0.2.7](google-shopping-merchant-products-v0.2.6...google-shopping-merchant-products-v0.2.7) (2025-08-06) ### Features * [google-shopping-merchant-products] add products API client libraries for v1 ([#14183](#14183)) ([4ae9435](4ae9435)) </details> <details><summary>google-shopping-merchant-promotions: 0.1.9</summary> ## [0.1.9](google-shopping-merchant-promotions-v0.1.8...google-shopping-merchant-promotions-v0.1.9) (2025-08-06) ### Features * [google-shopping-merchant-promotions] add promotions API client libraries for v1 ([#14185](#14185)) ([23ad885](23ad885)) </details> <details><summary>google-shopping-merchant-quota: 0.1.9</summary> ## [0.1.9](google-shopping-merchant-quota-v0.1.8...google-shopping-merchant-quota-v0.1.9) (2025-08-06) ### Features * add quota API for v1 ([29d65ad](29d65ad)) * add quota API for v1 ([#14177](#14177)) ([29d65ad](29d65ad)) </details> <details><summary>google-shopping-merchant-reports: 0.1.17</summary> ## [0.1.17](google-shopping-merchant-reports-v0.1.16...google-shopping-merchant-reports-v0.1.17) (2025-08-06) ### Features * [google-shopping-merchant-reports] Add additional YouTube report fields to Merchant reports endpoint ([#14166](#14166)) ([b5678de](b5678de)) * [google-shopping-merchant-reports] add reports API client libraries for v1 ([#14186](#14186)) ([7752ebf](7752ebf)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

3 participants

@tseaver @dhermes @googlebot