perf(bigquery): remove redundant array deepcopy #10139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
deepcopy can be a very costly operation when considering large arrays with complex nested objects. refactor helpers to allow recursive conversion without copying arrays.
googlebot added the cla: yes 
IlyaFaer added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run IlyaFaer added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
plamut added the do not merge 
Contributor
| Starting the repo split, please do not merge. |
Contributor
| The repo split for BigQuery is done, please open the PR in the new repo, thanks! |
Contributor
| Superseded by googleapis/python-bigquery#26 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Deepcopy can be a very costly operation when considering large arrays with complex nested objects.
Refactor helpers to allow recursive conversion without copying arrays.
Fixes #10138 🦕