feat(pubsublite): Enable compression for publish #7545
Conversation
codyoss changed the title 
product-auto-label bot added the api: pubsublite 
| configPollPeriod time.Duration | ||
| | ||
| // Whether compression is disabled. Compression is enabled by default. | ||
| DisableCompression bool |
There was a problem hiding this comment.
Can you change this to EnableCompression optional.Bool for consistency with EnableIdempotence in https://github.com/googleapis/google-cloud-go/pull/7390/files (not merged yet).
Also, if you haven't already, could you ensure the integration tests pass by running locally in the pscompat dir: go test -race -v. The presubmit checks run tests with -short, which skips the integration tests.
Also, looks like the unit tests need updating: https://source.cloud.google.com/results/invocations/6d293971-fecf-4018-bfc8-9d753e586309/targets/cloud-devrel%2Fclient-libraries%2Fgo%2Fgoogle-cloud-go%2Fpresubmit%2Flatest-version/log
There was a problem hiding this comment.
I just merged the idempotence PR.
tmdiep changed the title | pubClient, err := newPublisherClient(ctx, region, opts...) | ||
| var publishOpts = opts | ||
| if settings.EnableCompression { | ||
| publishOpts = append([]option.ClientOption{option.WithGRPCDialOption(grpc.WithDefaultCallOptions(grpc.UseCompressor("gzip")))}, opts...) |
There was a problem hiding this comment.
Could you use gzip.Name instead of the string. This also causes the gzip compressor to be registered.
product-auto-label bot added the stale: old product-auto-label bot added stale: extraold 
| Is this still needed or should we close it? |
4 participants
This is the equivalent of googleapis/java-pubsublite#1360