This repository was archived by the owner on Dec 8, 2021. It is now read-only.
feat: add efficient move support to mutation builder temporaries #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
googlebot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #989 +/- ## ========================================== - Coverage 94.26% 94.22% -0.05% ========================================== Files 95 159 +64 Lines 4080 10834 +6754 ========================================== + Hits 3846 10208 +6362 - Misses 234 626 +392
Continue to review full report at Codecov.
|
coryan approved these changes Oct 27, 2019
Contributor
coryan left a comment
coryan left a comment There was a problem hiding this comment.
and the testing strategy makes perfect sense.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
devjgm added a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
…gleapis/google-cloud-cpp-spanner#989) Fixes: googleapis/google-cloud-cpp-spanner#379 Most of the testing for this is done via static_asserts that ensure that a chain of method calls results in a call to .Build() that returns an rvalue. That ensures that the right functions are being called. Then I actually call the code and test that it works, but this part of the test doesn't really verify that moving happened, just that the code path works.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes: #379
Most of the testing for this is done via
static_asserts that ensure that a chain of method calls results in a call to.Build()that returns an rvalue. That ensures that the right functions are being called. Then I actually call the code and test that it works, but this part of the test doesn't really verify that moving happened, just that the code path works.This change is