This repository was archived by the owner on Dec 8, 2021. It is now read-only.
chore!: renamed QueryResult -> RowStream #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
googlebot added the cla: yes 
coryan approved these changes Oct 24, 2019
Contributor
coryan left a comment
coryan left a comment There was a problem hiding this comment.
Reviewed 17 of 17 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@ ## master #978 +/- ## ========================================== - Coverage 94.22% 94.14% -0.08% ========================================== Files 159 159 Lines 10623 10619 -4 ========================================== - Hits 10009 9997 -12 - Misses 614 622 +8
Continue to review full report at Codecov.
|
devjgm added a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
…-spanner#978) Fixes googleapis/google-cloud-cpp-spanner#977 Renames QueryResult -> RowStream for the reasons described in googleapis/google-cloud-cpp-spanner#977. Also standardized on variable naming: The variable used to store the results of a client.Read(...) or client.ExecuteQuery(...) is always named rows now, which I think reads nicely in the code. This PR is a semantic no-op. Only a rename.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #977
Renames
QueryResult->RowStreamfor the reasons described in #977. Also standardized on variable naming: The variable used to store the results of aclient.Read(...)orclient.ExecuteQuery(...)is always namedrowsnow, which I think reads nicely in the code.This PR is a semantic no-op. Only a rename.
This change is