Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Conversation

@devjgm
Copy link
Contributor

@devjgm devjgm commented May 5, 2020

This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2020
@devjgm devjgm marked this pull request as ready for review May 5, 2020 17:30
@devjgm devjgm requested review from coryan, devbww, mr-salty and scotthart May 5, 2020 17:31
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 14 of 14 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @devbww, @mr-salty, and @scotthart)

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #1489 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1489 +/- ## ======================================= Coverage 95.59% 95.59% ======================================= Files 194 193 -1 Lines 15926 15907 -19 ======================================= - Hits 15224 15207 -17  + Misses 702 700 -2 
Impacted Files Coverage Δ
google/cloud/spanner/internal/polling_loop.h 83.33% <0.00%> (-9.53%) ⬇️
google/cloud/spanner/keys.h 100.00% <0.00%> (ø)
google/cloud/spanner/transaction.h 100.00% <0.00%> (ø)
google/cloud/spanner/internal/session.h 100.00% <0.00%> (ø)
google/cloud/spanner/session_pool_options.h 100.00% <0.00%> (ø)
google/cloud/spanner/internal/transaction_impl.h 100.00% <0.00%> (ø)
...cloud/spanner/internal/partial_result_set_resume.h 100.00% <0.00%> (ø)
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 91.96% <0.00%> (ø)
...oogle/cloud/spanner/internal/instance_admin_stub.h
...anner/integration_tests/client_integration_test.cc 97.78% <0.00%> (+<0.01%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e61a1e...09959d1. Read the comment docs.

@devjgm devjgm merged commit 45cccc0 into googleapis:master May 5, 2020
@devjgm devjgm deleted the update-cmakefiles branch May 5, 2020 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants