Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Apr 29, 2020

Fixes googleapis/google-cloud-cpp#3610


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2020
@coryan coryan marked this pull request as ready for review April 29, 2020 20:08
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #1473 into master will increase coverage by 0.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1473 +/- ## ========================================== + Coverage 94.85% 95.59% +0.74%  ========================================== Files 194 192 -2 Lines 15963 15915 -48 ========================================== + Hits 15141 15214 +73  + Misses 822 701 -121 
Impacted Files Coverage Δ
google/cloud/spanner/client_test.cc 94.66% <100.00%> (+0.12%) ⬆️
...le/cloud/spanner/database_admin_connection_test.cc 99.72% <100.00%> (+<0.01%) ⬆️
...le/cloud/spanner/instance_admin_connection_test.cc 99.47% <100.00%> (+<0.01%) ⬆️
...gle/cloud/spanner/internal/connection_impl_test.cc 98.01% <100.00%> (+0.04%) ⬆️
google/cloud/spanner/internal/log_wrapper_test.cc 100.00% <100.00%> (ø)
...spanner/internal/partial_result_set_resume_test.cc 100.00% <100.00%> (ø)
...spanner/internal/partial_result_set_source_test.cc 100.00% <100.00%> (ø)
google/cloud/spanner/keys_test.cc 93.06% <100.00%> (+0.06%) ⬆️
google/cloud/spanner/mutations_test.cc 100.00% <100.00%> (ø)
google/cloud/spanner/results_test.cc 93.75% <100.00%> (+0.29%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904198c...5f09a42. Read the comment docs.

@devjgm
Copy link
Contributor

devjgm commented Apr 29, 2020

I swear, I tried this earlier and couldn't get it to work... glad it's working now. Not sure what I did wrong, but thanks.

@coryan coryan merged commit ca08e88 into googleapis:master Apr 29, 2020
@coryan coryan deleted the ci-enable-ccache-clang-3.8 branch April 29, 2020 20:51
devjgm pushed a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants