Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Apr 15, 2020

This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2020
@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #1467 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1467 +/- ## ========================================== - Coverage 95.58% 95.55% -0.04%  ========================================== Files 192 195 +3 Lines 15824 15824 ========================================== - Hits 15126 15121 -5  - Misses 698 703 +5 
Impacted Files Coverage Δ
google/cloud/spanner/internal/log_wrapper.h 75.00% <0.00%> (-9.62%) ⬇️
google/cloud/spanner/internal/spanner_stub.cc 76.34% <0.00%> (-1.08%) ⬇️
google/cloud/spanner/value.h 92.19% <0.00%> (-0.11%) ⬇️
...anner/integration_tests/client_integration_test.cc 97.78% <0.00%> (-0.02%) ⬇️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 91.96% <0.00%> (-0.01%) ⬇️
google/cloud/spanner/transaction.h 100.00% <0.00%> (ø)
google/cloud/spanner/samples/samples.cc 90.21% <0.00%> (ø)
google/cloud/spanner/internal/transaction_impl.h 100.00% <0.00%> (ø)
...oogle/cloud/spanner/internal/database_admin_stub.h 100.00% <0.00%> (ø)
google/cloud/spanner/instance_admin_connection.h 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b47642...5f5c2f4. Read the comment docs.

Copy link
Contributor

@mr-salty mr-salty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @devbww, @devjgm, and @scotthart)

@coryan coryan merged commit ff91d3d into googleapis:master Apr 15, 2020
@coryan coryan deleted the fix-shellcheck-warnings branch April 15, 2020 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants