Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

cleanup: make use of the new Client::Commit(Mutations) overload #1359

Merged
merged 1 commit into from
Mar 12, 2020
Merged

cleanup: make use of the new Client::Commit(Mutations) overload #1359

merged 1 commit into from
Mar 12, 2020

Conversation

@devbww
Copy link
Contributor

@devbww devbww commented Mar 12, 2020 •
edited
Loading

Use the new Commit() helper whenever the mutator ignores the
passed Transaction and simply returns a Mutations value.

This change is Reviewable
@devbww
cleanup: make use of the new Client::Commit(Mutations) overload
6887972 
Use the new `Commit()` helper whenever the mutator ignore the passed `Transaction` and simply returns a `Mutations` value.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2020
@codecov
Copy link

codecov bot commented Mar 12, 2020 •
edited
Loading

Codecov Report

Merging #1359 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1359 +/- ## ========================================== - Coverage 94.77% 94.72% -0.06%  ========================================== Files 178 179 +1 Lines 13873 13845 -28 ========================================== - Hits 13148 13114 -34  - Misses 725 731 +6
Impacted Files Coverage Δ
google/cloud/spanner/samples/samples.cc 89.5% <100%> (-0.37%) ⬇️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 91.96% <100%> (-0.02%) ⬇️
...r/integration_tests/data_types_integration_test.cc 100% <100%> (ø) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 81.48% <100%> (-1.86%) ⬇️
...nner/benchmarks/single_row_throughput_benchmark.cc 90.78% <100%> (-0.03%) ⬇️
...anner/integration_tests/client_integration_test.cc 98.26% <100%> (-0.05%) ⬇️
google/cloud/spanner/internal/retry_loop.h 95.45% <0%> (-4.55%) ⬇️
google/cloud/spanner/internal/polling_loop.h 91.89% <0%> (-2.71%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a573cf...6887972. Read the comment docs.
@devbww devbww marked this pull request as ready for review March 12, 2020 05:23
@devbww devbww requested review from coryan, devjgm and mr-salty March 12, 2020 05:24
coryan
coryan approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @devjgm and @mr-salty)
@devbww devbww merged commit 9fce0a6 into googleapis:master Mar 12, 2020
@devbww devbww deleted the commit-mutations branch March 12, 2020 15:18
devjgm pushed a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
@devbww
cleanup: make use of the new Client::Commit(Mutations) overload (goog…
088cf97 
…leapis/google-cloud-cpp-spanner#1359) Use the new `Commit()` helper whenever the mutator ignores the passed `Transaction` and simply returns a `Mutations` value.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants

@devbww @coryan @googlebot