Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Conversation

@devjgm
Copy link
Contributor

@devjgm devjgm commented Feb 21, 2020

Deletes our own internal/range_from_pagination.h
Fixes: #1256


This change is Reviewable

Deletes our own internal/range_from_pagination.h Fixes: googleapis#1256
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2020
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #1278 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1278 +/- ## ========================================== + Coverage 94.58% 94.63% +0.05%  ========================================== Files 178 177 -1 Lines 13851 13795 -56 ========================================== - Hits 13101 13055 -46  + Misses 750 740 -10
Impacted Files Coverage Δ
...ud/spanner/integration_tests/client_stress_test.cc 82.45% <0%> (-0.88%) ⬇️
google/cloud/spanner/internal/session.h 100% <0%> (ø) ⬆️
google/cloud/spanner/internal/transaction_impl.h 100% <0%> (ø) ⬆️
google/cloud/spanner/connection_options.h 100% <0%> (ø) ⬆️
...cloud/spanner/internal/partial_result_set_resume.h 100% <0%> (ø) ⬆️
google/cloud/spanner/session_pool_options.h 100% <0%> (ø) ⬆️
google/cloud/spanner/transaction.h 100% <0%> (ø) ⬆️
google/cloud/spanner/connection_options_test.cc 100% <0%> (ø) ⬆️
...oogle/cloud/spanner/internal/database_admin_stub.h
...oogle/cloud/spanner/internal/instance_admin_stub.h 100% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d84bfa...5f9dd39. Read the comment docs.

@devjgm devjgm merged commit 9572c85 into googleapis:master Feb 21, 2020
@devjgm devjgm deleted the pagination branch February 21, 2020 16:47
devjgm added a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants