Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Feb 7, 2020

We never explained that users need to load a Starlark function to use
http_archive(). Also fix the documentation to use the current release,
this will get "stale", but would be still functional and we warn users
to update the version and SHA256 in the comments.

Since I was fixing this I also updated the INSTALL.md file (and its
generator) with the changes from #1252, thanks to @antfitch for proposing
these improvements.


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 7, 2020
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #1254 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1254 +/- ## ========================================== - Coverage 94.87% 94.83% -0.04%  ========================================== Files 181 181 Lines 13794 13792 -2 ========================================== - Hits 13087 13080 -7  - Misses 707 712 +5
Impacted Files Coverage Δ
...loud/spanner/internal/partial_result_set_resume.cc 90.9% <0%> (-4.55%) ⬇️
google/cloud/spanner/internal/polling_loop.h 91.89% <0%> (-2.71%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 81.57% <0%> (-1.76%) ⬇️
google/cloud/spanner/internal/spanner_stub.cc 68.47% <0%> (-1.09%) ⬇️
google/cloud/spanner/value.h 92.8% <0%> (-0.11%) ⬇️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 92.37% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2c79b...252fbfb. Read the comment docs.

We never explained that users need to load a Starlark function to use `http_archive()`. Also fix the documentation to use the current release, this will get "stale", but would be still functional and we warn users to update the version and SHA256 in the comments. Since I was fixing this I also updated the INSTALL.md file (and its generator) with the changes from #1252.
@coryan coryan merged commit 45961b8 into googleapis:master Feb 14, 2020
@coryan coryan deleted the fix-instructions-for-WORKSPACE-file branch February 14, 2020 20:23
devjgm pushed a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
…d-cpp-spanner#1254) We never explained that users need to load a Starlark function to use `http_archive()`. Also fix the documentation to use the current release, this will get "stale", but would be still functional and we warn users to update the version and SHA256 in the comments. Since I was fixing this I also updated the INSTALL.md file (and its generator) with the changes from googleapis/google-cloud-cpp-spanner#1252.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants