Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Nov 24, 2019

Add an overload for spanner::MakeConnection() which allows users to
override the retry and backoff policies. Implement an example showing
how to use this overload.

Fixes #244


This change is Reviewable

Add an overload for `spanner::MakeConnection()` which allows users to override the retry and backoff policies. Implement an example showing how to use this overload.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 24, 2019
@codecov
Copy link

codecov bot commented Nov 24, 2019

Codecov Report

Merging #1111 into master will increase coverage by 1.15%.
The diff coverage is 96.55%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1111 +/- ## ========================================== + Coverage 93.37% 94.53% +1.15%  ========================================== Files 164 164 Lines 11913 11930 +17 ========================================== + Hits 11124 11278 +154  + Misses 789 652 -137
Impacted Files Coverage Δ
google/cloud/spanner/client.h 100% <ø> (ø) ⬆️
google/cloud/spanner/client.cc 83.33% <100%> (-0.33%) ⬇️
google/cloud/spanner/samples/samples.cc 86.08% <95.83%> (+8.72%) ⬆️
google/cloud/spanner/internal/polling_loop.h 91.89% <0%> (-2.71%) ⬇️
google/cloud/spanner/internal/spanner_stub.cc 68.13% <0%> (-2.2%) ⬇️
...on_tests/rpc_failure_threshold_integration_test.cc 85.55% <0%> (-0.16%) ⬇️
google/cloud/spanner/value.h 92.7% <0%> (-0.11%) ⬇️
google/cloud/spanner/keys.h 100% <0%> (ø) ⬆️
google/cloud/spanner/transaction.h 100% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4f9d6...3755477. Read the comment docs.

@coryan coryan merged commit 9a64e06 into googleapis:master Nov 25, 2019
@coryan coryan deleted the retry-examples branch November 25, 2019 15:12
devjgm pushed a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
…d-cpp-spanner#1111) Add an overload for `spanner::MakeConnection()` which allows users to override the retry and backoff policies. Implement an example showing how to use this overload.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants