Skip to content

fix(types): add full type annotations to oauth utils and exceptions (#1508) #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(types): add full type annotations to oauth utils and exceptions (#1508) #1718

wants to merge 1 commit into from

Conversation

cureprotocols
Copy link

This PR contributes to #1508 by fully typing both google/oauth2/utils.py and google/auth/exceptions.py under --strict mode.

✅ Changes

  • Added explicit return and argument types across both files.
  • Enhanced OAuthError with optional response_body to allow better downstream debugging.
  • mypy --strict verified ✅ on both files.

These changes are isolated, fully backward-compatible, and bring the codebase closer to strict typing compliance.

Let me know if anything else needs to be adjusted!
@cureprotocols cureprotocols requested review from a team as code owners April 3, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@cureprotocols