Let OS select an available port when running TestInstalledAppFlow #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| please fix linters, but other than that looks good |
nolanleastin force-pushed the neastin-378871875 branch from ce583db to 1d91475 Compare nolanleastin changed the title nolanleastin force-pushed the neastin-378871875 branch from 1d91475 to 619fc18 Compare nolanleastin changed the title nolanleastin force-pushed the neastin-378871875 branch from 619fc18 to b4bcc82 Compare tests.unit.test_flow.TestInstalledAppFlow attempts to create a new server at the specified host:port. New server creation occasionally results in 'address already in use' because the socket will be unavailable for a period of time after the socket is closed, resulting in flaky test failures. Work around this in the tests by letting the OS pick an available port each time. Fixes #381
nolanleastin force-pushed the neastin-378871875 branch from b4bcc82 to efc17ae Compare 
harkamaljot approved these changes Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
tests.unit.test_flow.TestInstalledAppFlow attempts to create a new server at the specified host:port. New server creation occasionally results in 'address already in use' because the socket will be unavailable for a period of time after the socket is closed, resulting in flaky test failures.
Work around this in the tests by letting the OS pick an available port each time.
Fixes #381