Add back in deprecated methods in ServiceAccountJwtAccessCredentials #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
googlebot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #238 +/- ## ============================================ - Coverage 78.33% 78.23% -0.11% Complexity 330 330 ============================================ Files 21 21 Lines 1445 1447 +2 Branches 158 158 ============================================ Hits 1132 1132 - Misses 235 237 +2 Partials 78 78
Continue to review full report at Codecov.
|
sduskis suggested changes Mar 27, 2019
| * @deprecated Use {@link #newBuilder()} instead. This constructor will either be deleted or made | ||
| * private in a later version. | ||
| */ | ||
| private ServiceAccountJwtAccessCredentials(String clientId, String clientEmail, |
Contributor
There was a problem hiding this comment.
IMHO, this constructor should continue to be private.
sduskis approved these changes Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
To be deleted at a later time.