Improve log output when detecting GCE #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Improving the log output when unexpected exceptions occur while determining if the client is running on Google Compute Engine. Moving the stacktrace to be FINE output since stacktraces are alarming. Making the INFO level log message occur only once instead of potentially many times. Further improvements to googleapis#199 and googleapis#198
googlebot added the cla: yes 
chingor13 approved these changes Dec 19, 2018
chingor13 added the kokoro:force-run 
kokoro-team removed the kokoro:force-run 
chingor13 added the kokoro:force-run kokoro-team removed the kokoro:force-run This was referenced Dec 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@chingor13 Thanks for addressing this originally, I think this improves on what you did by fixing an issue with repeated log outputs. It also makes the stack traces only output on
LogLevel.FINElevel since we have people regularly getting 3 repeated stack traces every time they run is alarming and not very helpful.Moving the stacktrace to be FINE output since stacktraces are alarming.
Making the INFO level log message occur only once instead of potentially many times.
Further improvements to #199 and #198