Option to suppress end user credentials warning. #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Defining a new environment variable SUPPRESS_GCLOUD_CREDS_WARNING. Setting this to true suppresses the end user credentials warning. Fixes googleapis#193
googlebot added the cla: yes 
chingor13 reviewed Nov 12, 2018
Contributor
chingor13 left a comment
chingor13 left a comment There was a problem hiding this comment.
One nit, otherwise LGTM.
oauth2_http/java/com/google/auth/oauth2/DefaultCredentialsProvider.java Outdated Show resolved Hide resolved
chingor13 added the kokoro:force-run 
kokoro-team removed the kokoro:force-run 
Codecov Report
@@ Coverage Diff @@ ## master #207 +/- ## ========================================= Coverage ? 75.86% Complexity ? 314 ========================================= Files ? 20 Lines ? 1355 Branches ? 149 ========================================= Hits ? 1028 Misses ? 254 Partials ? 73
Continue to review full report at Codecov.
|
chingor13 added the kokoro:force-run kokoro-team removed kokoro:force-run chingor13 approved these changes Nov 13, 2018
Contributor Author
| @chingor13 Thank you. |
This was referenced Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Defining a new environment variable SUPPRESS_GCLOUD_CREDS_WARNING.
Setting this to true suppresses the end user credentials warning.
Fixes #193