feat: add mtls support to GoogleNetHttpTransport and GoogleApacheHttpTransport #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
elharo suggested changes Nov 2, 2020
chingor13 requested changes Nov 4, 2020
...ient/src/main/java/com/google/api/client/googleapis/apache/v2/GoogleApacheHttpTransport.java Outdated Show resolved Hide resolved
...pi-client/src/main/java/com/google/api/client/googleapis/javanet/GoogleNetHttpTransport.java Outdated Show resolved Hide resolved
...pi-client/src/main/java/com/google/api/client/googleapis/javanet/GoogleNetHttpTransport.java Outdated Show resolved Hide resolved
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java Outdated Show resolved Hide resolved
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java Outdated Show resolved Hide resolved
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java Outdated Show resolved Hide resolved
| BTW, google-http-client 1.38.0 is now available and updated in master |
chingor13 requested changes Nov 4, 2020
...pi-client/src/main/java/com/google/api/client/googleapis/javanet/GoogleNetHttpTransport.java Outdated Show resolved Hide resolved
...ient/src/main/java/com/google/api/client/googleapis/apache/v2/GoogleApacheHttpTransport.java Outdated Show resolved Hide resolved
...ient/src/main/java/com/google/api/client/googleapis/apache/v2/GoogleApacheHttpTransport.java Outdated Show resolved Hide resolved
...pi-client/src/main/java/com/google/api/client/googleapis/javanet/GoogleNetHttpTransport.java Outdated Show resolved Hide resolved
.../src/test/java/com/google/api/client/googleapis/apache/v2/GoogleApacheHttpTransportTest.java Outdated Show resolved Hide resolved
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java Outdated Show resolved Hide resolved
chingor13 reviewed Nov 4, 2020
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java Outdated Show resolved Hide resolved
chingor13 reviewed Nov 4, 2020
google-api-client/src/main/java/com/google/api/client/googleapis/util/Utils.java Outdated Show resolved Hide resolved
refactor: implement MtlsUtils.MtlsProvider interface with default implementation
chingor13 requested changes Nov 5, 2020
google-api-client/src/main/java/com/google/api/client/googleapis/util/MtlsUtils.java Show resolved Hide resolved
google-api-client/src/test/java/com/google/api/client/googleapis/MtlsTransportBaseTest.java Outdated Show resolved Hide resolved
google-api-client/src/test/java/com/google/api/client/googleapis/MtlsTransportBaseTest.java Show resolved Hide resolved
google-api-client/src/main/java/com/google/api/client/googleapis/util/MtlsUtils.java Outdated Show resolved Hide resolved
elharo reviewed Nov 6, 2020
google-api-client/src/main/java/com/google/api/client/googleapis/mtls/MtlsUtils.java Outdated Show resolved Hide resolved
google-api-client/src/main/java/com/google/api/client/googleapis/mtls/MtlsUtils.java Outdated Show resolved Hide resolved
google-api-client/src/main/java/com/google/api/client/googleapis/mtls/MtlsUtils.java Outdated Show resolved Hide resolved
elharo suggested changes Nov 9, 2020
google-api-client/src/main/java/com/google/api/client/googleapis/mtls/MtlsUtils.java Outdated Show resolved Hide resolved
elharo approved these changes Nov 10, 2020
google-api-client/src/main/java/com/google/api/client/googleapis/mtls/MtlsUtils.java Outdated Show resolved Hide resolved
chingor13 requested changes Nov 10, 2020
google-api-client/src/main/java/com/google/api/client/googleapis/mtls/package-info.java Outdated Show resolved Hide resolved
…is/mtls/package-info.java Co-authored-by: Jeff Ching <chingor@google.com>
chingor13 approved these changes Nov 10, 2020
chingor13 added the automerge 
gcf-merge-on-green bot removed the automerge gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 10, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.31.0](https://www.github.com/googleapis/google-api-java-client/compare/v1.30.11...v1.31.0) (2020-11-10) ### Features * add GoogleApacheHttpTransport that uses the v2 ApacheHttpTransport implementation ([#1568](https://www.github.com/googleapis/google-api-java-client/issues/1568)) ([d0dbca7](https://www.github.com/googleapis/google-api-java-client/commit/d0dbca720479f1ca8627c58eda195857ea0b2423)) * add mtls support to GoogleNetHttpTransport and GoogleApacheHttpTransport ([#1619](https://www.github.com/googleapis/google-api-java-client/issues/1619)) ([1d8304c](https://www.github.com/googleapis/google-api-java-client/commit/1d8304c6311e910293b800ffdbf0bb6f19cf7fff)) ### Dependencies * update dependency com.google.appengine:appengine-api-1.0-sdk to v1.9.83 ([#1622](https://www.github.com/googleapis/google-api-java-client/issues/1622)) ([10bb904](https://www.github.com/googleapis/google-api-java-client/commit/10bb90441c90cb5ea7045a1ac5d39d669fad963d)) * update dependency com.google.oauth-client:google-oauth-client-bom to v1.31.2 ([#1623](https://www.github.com/googleapis/google-api-java-client/issues/1623)) ([5942561](https://www.github.com/googleapis/google-api-java-client/commit/594256120e4eb37b0f3ca386f69542b68b53d05b)) * update google-http-client to v1.38.0 ([#1620](https://www.github.com/googleapis/google-api-java-client/issues/1620)) ([bb63ded](https://www.github.com/googleapis/google-api-java-client/commit/bb63ded8846cd515c993c288728063f35e226ec5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.