Skip to content

Conversation

MattCardoso
Copy link

Small change on how constructor(init) access the configuration data

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@MattCardoso
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@MattCardoso
Copy link
Author

Just adding some more context:
The way it is now, the constructor will always get an empty object/dict.
If I change the name of the configuration in googleads.yaml from report_downloader_headers to report_download_headers it will throw a warning: UserWarning: Could not recognize the following keys: {'report_download_headers':...} because it is not listed in _OPTIONAL_INIT_VALUES

@BenRKarl BenRKarl changed the base branch from master to main August 23, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants