Fix dartfmt's IsAvailable() method. #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
d927656 changed the dartfmt_executable flag from a string to a list, but didn't change the use inside IsAvailable(), leading to: Failed to evaluate whether formatter dartfmt is available: Vim(return) :E730: Using a List as a String The change uses the ResolveFlagToArray() helper in both IsAvailable() and FormatRange() (which incidentally also allows defining the flag using a Function), and updates the documentation for all flags using ResolveFlagToArray() to use the same phrasing. Fixes google#190.
| I'm not sure why the neovim tests are failing, but it doesn't seem to be due to this change. Unfortunately that looks like that failure also aborts the Vim tests, but those do pass locally. |
dbarnett approved these changes Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
d927656 changed the
dartfmt_executableflag from a string to a list, but didn't change the use inside IsAvailable(), leading to:The change uses the
ResolveFlagToArray()helper in bothIsAvailable()andFormatRange()(which incidentally also allows defining the flag using a Function), and updates the documentation for all flags usingResolveFlagToArray()to use the same phrasing.Fixes #190.