Skip to content

Add mixformat to handle Elixir #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 18, 2022
Merged

Add mixformat to handle Elixir #201

merged 16 commits into from
Nov 18, 2022

Conversation

@flwyd
Copy link
Contributor

@flwyd flwyd commented Oct 20, 2022

Fixes #200.
dbarnett
dbarnett suggested changes Nov 13, 2022
View reviewed changes
autoload/codefmt/mixformat.vim Outdated
let l:cmd = codefmt#formatterhelpers#ResolveFlagToArray('mix_executable')
" Specify stdin as the file
let l:cmd = l:cmd + ['format', '--stdin-filename=' . l:filename, '-']
let l:dir = l:filename == 'stdin.exs' ? getcwd() : s:findMixDir(l:filename)
Copy link
Contributor

@dbarnett dbarnett Nov 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can stdin.exs be a valid filename here, or is it just supposed to be a placeholder value? If so, would this give the right behavior for a file explicitly named stdin.exs?
Copy link
Contributor Author

@flwyd flwyd Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. I moved l:dir assignment into the if empty block and added a comment giving context to stdin.exs.
@dbarnett dbarnett merged commit 3494825 into google:master Nov 18, 2022
@dbarnett
Copy link
Contributor

dbarnett commented Nov 18, 2022

Thanks, Trevor!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@flwyd @dbarnett