Tests: Fix several failures related to formatter precedence #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes several vroom tests that wrongly assume their formatter will be the default for a given filetype and started failing when I reordered the formatter registrations in b1b5109. Note those precedence changes could really affect users, but only if they're relying on defaults and have multiple installed formatters for those same filetypes. If so, it's easily resolved by explicitly specifying a formatter name or uninstalling unwanted formatters.
| I don't think there's any "correct" precedence among these default formatters in general, but LMK if anyone does have any precedence you think is important to guarantee. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes several vroom tests that wrongly assume their formatter will be the default for a given filetype and started failing when I reordered the formatter registrations in b1b5109.
Note those precedence changes could really affect users, but only if they're relying on defaults and have multiple installed formatters for those same filetypes. If so, it's easily resolved by explicitly specifying a formatter name or uninstalling unwanted formatters.