Skip to content

Conversation

zinovyev
Copy link

This pull request adds a rubocop support for Ruby and ERuby file types.
Solves #30

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@zinovyev
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@dbarnett dbarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you see about adding a vroom test file with examples of rubocop's expected input/outputs, like other formatters have under the vroom/ directory?

let l:formatted = split(l:result.stdout, "\n")

let l:before = a:startline > 1 ? l:lines[ : a:startline - 2] : []
let l:full_formatted = l:before + l:formatted[1:] + l:lines[a:endline :]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This formatted[1:] is a little strange… does the formatter output an extra first line to stdout that's not part of the output?

ar1ja pushed a commit to ar1ja/vim-codefmt that referenced this pull request Jan 15, 2022
Signed-off-by: Ari Archer <truncateddinosour@gmail.com>
@akveritas
Copy link
Contributor

Is anyone still working on this? I was about to start doing this when I found it already done and pending review.

@fowles
Copy link
Contributor

fowles commented May 27, 2023

Is anyone still working on this? I was about to start doing this when I found it already done and pending review.

I suspect that David was waiting for a response to his question. If you want to take over and send a new PR that is reasonable

dbarnett pushed a commit that referenced this pull request Jun 1, 2023
Note: This change is based on an abandoned change by zinovyev #132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 participants