Skip to content

If the buffer has a path, pass it to buildifier as -path PATH. #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2018
Merged

If the buffer has a path, pass it to buildifier as -path PATH. #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion autoload/codefmt/buildifier.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,12 @@ function! codefmt#buildifier#GetFormatter() abort
" @flag(buildifier)
" @throws ShellError
function l:formatter.Format() abort
let l:cmd = s:plugin.Flag('buildifier_executable')
let l:cmd = [ s:plugin.Flag('buildifier_executable') ]
let l:fname = expand('%:p')
if !empty(l:fname)
let l:cmd += ['-path', l:fname]
endif

let l:input = join(getline(1, line('$')), "\n")
try
let l:result = maktaba#syscall#Create(l:cmd).WithStdin(l:input).Call()
Expand Down
12 changes: 8 additions & 4 deletions vroom/buildifier.vroom
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
The built-in buildifier formatter knows how to format Bazel BUILD files. If you
aren't familiar with basic codefmt usage yet, see main.vroom first.
The built-in buildifier formatter knows how to format Bazel BUILD and .bzl
files. If you aren't familiar with basic codefmt usage yet, see main.vroom
first.

We'll set up codefmt and configure the vroom environment, then jump into some
examples.
Expand Down Expand Up @@ -38,14 +39,17 @@ buildifier_executable flag if the default of "buildifier" doesn't work.
$ )
:Glaive codefmt buildifier_executable='buildifier'

The bzl filetype will use the buildifier formatter by default.
The bzl filetype will use the buildifier formatter by default. The path to the
file being edited is passed to buildifier so that it can adjust to whether the
file is a BUILD or .bzl file.

@clear
% foo_library(name = "foo", srcs = ["bar.js"],)

:silent file /foo/bar/BUILD
:set filetype=bzl
:FormatCode
! buildifier .*
! buildifier -path /foo/bar/BUILD .*
$ foo_library(
$ name = "foo",
$ srcs = ["bar.js"],
Expand Down