Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

tighten test_monte_carlo_bias_is_zero bound #1727

Open
austereantelope wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tighten test_monte_carlo_bias_is_zero bound #1727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion trax/rl/advantages_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def test_monte_carlo_bias_is_zero(self):
(bias, _) = estimate_advantage_bias_and_variance(
advantages.monte_carlo, margin=3
)
np.testing.assert_allclose(bias, 0, atol=0.1)
np.testing.assert_allclose(bias, 0, atol=0.04)

def test_td_k_variance_lower_than_monte_carlo(self):
(_, var_td_3) = estimate_advantage_bias_and_variance(
Expand Down