Misc cleanups so we can cut a release and push the podspec. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Add in tvOS. Update text for it also. - Require a min version of the SessionFetcher with the needed support.
We've seen failures in tests when using xctool that we can't repro when using xcodebuild, so even though xctool does a better job of managing the simulators it doesn't seem to be safe to trust.
- Add a dispatch group to the ticket so the wait method can delay while callbacks and notifications are in flight. - End the wait method's spinning when the ticket has been canceled rather than let it time out on cancel, since cancel suppresses the ticket's callback. - Move the postNotificationOnMainThread utility method to the ticket since it's now done on the ticket's callback group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.