Bugfix: Fixed Example projects so they work+ added ui improvement to help users. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…e to run the app whilst leaving the client secret blank. It would just re-open the validation sheet. feature: added placeholder text to tell the user that they should leave the client secret blank. I left the fields in, just in case they are going to be used for other projects/ in the future. admin: Added comments to state that the client secret should be blank so its understood easily by developers trying to use this. Hope these improvements help - Tested ok on latest Xcode 7.3.1
Closed
| // hardcoded into the source, but the sample application asks the | ||
| // developer for the strings | ||
| // Applications should have client ID hardcoded into the source. | ||
| // but the sample application asks the developer for the strings. |
Contributor Author
| @thomasvl Thanks for looking. I hope the fix above has addressed the review points. I removed one extra full stop to make sure it reads a bit clearer. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
bugfix: Removed Client Secret checking validation as it was impossible to run the app whilst leaving the client secret blank. It would just re-open the validation sheet.
feature: added placeholder text to tell the user that they should leave the client secret blank. I left the fields in, just in case they are going to be used for other projects/ in the future.
admin: Added comments to state that the client secret should be blank so its understood easily by developers trying to use this.
Hope these improvements help -
Tested ok on latest Xcode 7.3.1