Skip to content

Feature/fix missing documentation #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomasvl merged 7 commits into from
Aug 15, 2016
Merged

Feature/fix missing documentation #20

thomasvl merged 7 commits into from
Aug 15, 2016
+44 −1

Conversation

@grantkemp
Copy link
Contributor

@grantkemp grantkemp commented Aug 14, 2016

improvements to Example Readme to make sure my mistakes aren't made by others
@thomasvl
Copy link
Member

thomasvl commented Aug 15, 2016

Rather than putting this in the one example directory, why not make it generic and put it at the top of the Examples directory as the advice should apply to all of them?
@grantkemp
admin: moved Readme to parent folder so it applies across all example…
8510f32 
… projects. doc: added section on generating OAuth client Id tidy: Formatting and grammar
thomasvl
thomasvl reviewed Aug 15, 2016
View reviewed changes
Examples/README.MD Outdated
```

##Requirements to use
These example apps need an oAuth Client key, which you can obtain from the[Google Developer Console](https://console.developers.google.com/).
Copy link
Member

@thomasvl thomasvl Aug 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want a space after "the" before the link to the console.
@grantkemp
Copy link
Contributor Author

grantkemp commented Aug 15, 2016

Just wanted to add one last item to the Readme to make it clear for novice users. Otherwise the warning is hidden in the comments and might get missed.
@thomasvl thomasvl merged commit 61b5dcd into google:master Aug 15, 2016
@thomasvl
Copy link
Member

thomasvl commented Aug 15, 2016

Sorry, you might need to spin a new pull request for that. As I think it arrived after I'd done a squashing merge
@grantkemp
Copy link
Contributor Author

grantkemp commented Aug 15, 2016 •
edited
Loading

Its ok, lets let it go.
I am going to try to create an additional example for myself using the Google Sign In Flow ( mentioned in the wiki ) assuming thats possible. It might be good to show a different approach to leverage this library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes

3 participants

@grantkemp @thomasvl @googlebot