refactor: fix revive.unused-parameter lint issues #3603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alexandear changed the title 
alexandear force-pushed the refactor/enable-revive-unused-parameter branch from 61cb862 to 2c28070 Compare 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #3603 +/- ## ======================================= Coverage 91.32% 91.32% ======================================= Files 184 184 Lines 16143 16143 ======================================= Hits 14742 14742 Misses 1227 1227 Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis approved these changes Jun 25, 2025
Collaborator
gmlewis left a comment
gmlewis left a comment There was a problem hiding this comment.
Thank you, @alexandear!
LGTM.
Merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR enables the
revive.unused-parameterrule and fixes the resulting lint issues, mostly in tests.Bug #3601 was discovered with the help of
revive.unused-parameter, so I propose enabling the rule to prevent these bugs in the future.