Skip to content

WIP: Add unit test for template literal concatenation (Issue #4148) #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+29 −0
Draft

WIP: Add unit test for template literal concatenation (Issue #4148) #4257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions test/com/google/javascript/jscomp/PeepholeFoldConstantsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2217,6 +2217,35 @@ public void testAssociativeFoldConstantsWithVariables() {
test("alert(12 & x & 20);", "alert(x & 4);");
}


@Test
public void testTemplateLiteralConcat() {
// --- Issue #4148 core case: template + template should merge

// string + template literal (with any order)
// string + string (already working)
// template literal + template literal (template literal can include referenced variable
// or valid HTML)

test(
"const x = 'X'; console.log('pre' + `${x}`);",
"const x = 'X'; console.log(`pre${x}`);");

test(
"""
var a = document.location.href;
console.log(`<h1>${a}</h1>` + `<p>The URL is ${a}.</p>`);
""",
"""
var a = document.location.href;
console.log(`<h1>${a}</h1><p>The URL is ${a}.</p>`);
"""
);

}



private void foldBigIntTypes(String js, String expected) {
test(
"function f(/** @type {bigint} */ x) { " + js + " }",
Expand Down