Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 16, 2022

Bumps @actions/github from 5.0.1 to 5.0.3.

Changelog

Sourced from @​actions/github's changelog.

5.0.3

    • Update to v2.0.1 of @actions/http-client #1087

5.0.2

  • Update to v2.0.0 of @actions/http-client
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Bumps [@actions/github](https://github.com/actions/toolkit/tree/HEAD/packages/github) from 5.0.1 to 5.0.3. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/github/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/github) --- updated-dependencies: - dependency-name: "@actions/github" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 16, 2022
@dependabot dependabot bot requested a review from a team May 16, 2022 09:01
Copy link
Contributor

@kamilsk kamilsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamilsk
Copy link
Contributor

kamilsk commented May 16, 2022

as I see https://github.com/golangci/golangci-lint-action/runs/6449053944 and

 # Update dist files if there is label dependencies - name: Update dist files if: github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'dependencies') run: | if [[ -z $(git status -s) ]] then echo "No change is required" else echo "Updating dist directory" git config --local user.name "dependabot[bot]" git config --local user.email "49699333+dependabot[bot]@users.noreply.github.com" git add --update git commit --message="Update dist files" git push fi 

it didn't work

@kamilsk
Copy link
Contributor

kamilsk commented May 16, 2022

maybe it's because it needs more time between events

image

image

@kamilsk kamilsk force-pushed the dependabot/npm_and_yarn/actions/github-5.0.3 branch from 61d4b90 to 16708a1 Compare May 16, 2022 09:59
@kamilsk kamilsk force-pushed the dependabot/npm_and_yarn/actions/github-5.0.3 branch from 16708a1 to c8e3f81 Compare May 16, 2022 10:01
@kamilsk kamilsk requested review from SVilgelm and ldez May 16, 2022 10:02
@kamilsk
Copy link
Contributor

kamilsk commented May 16, 2022

I updated the condition in .github/workflows/test.yml, please take a look

motivation is related to my prev comment #470 (comment) above, also, maybe it will be better to remove part with "dependencies" label

@kamilsk kamilsk requested review from kamilsk and removed request for kamilsk May 16, 2022 10:06
@ldez
Copy link
Member

ldez commented May 16, 2022

The step "Update dist files" is already skipped:

Screenshot 2022-05-16 at 12-29-00 Build software better together

So I don't understand why the files are generated.

@ldez
Copy link
Member

ldez commented May 16, 2022

The problem is not related to the step "Update dist files".

It's related to the previous step npm run all

@ldez ldez force-pushed the dependabot/npm_and_yarn/actions/github-5.0.3 branch from 1f311dd to c8e3f81 Compare May 16, 2022 10:46
@ldez
Copy link
Member

ldez commented May 16, 2022

I agree that the problem is related to the time between the creation of the PR and the addition of the label: when the PR is created the step "Update dist files" is skipped because the label is not here.

Note: I don't know if it's a problem with dependabot or the GitHub API.

@ldez ldez merged commit 6aefae2 into master May 16, 2022
@ldez ldez deleted the dependabot/npm_and_yarn/actions/github-5.0.3 branch May 16, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

3 participants