Skip to content

_content/tour/concurrency: add timestamps to default selection example for clearer visualization #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

_content/tour/concurrency: add timestamps to default selection example for clearer visualization #320

wants to merge 1 commit into from

Conversation

@murali-kri5hna
Copy link
Contributor

@murali-kri5hna murali-kri5hna commented May 11, 2025 •
edited
Loading

The existing default selection example lacks clear timing visualization.
This change displays timestamps alongside the output, helping learners
visualize:

  • The 50ms intervals of the default case
  • The 100ms intervals of the tick case
  • The immediate execution after tick events
  • The precise 500ms timing of the boom event

Enhances readability and understanding of Go's concurrency timing behavior.

Fixes golang/tour#1733
@gopherbot
Copy link
Contributor

This PR (HEAD: d53bb02) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/671715.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/671715.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/671715.
After addressing review feedback, remember to publish your drafts!
@murali-kri5hna murali-kri5hna changed the title Add timestamps to default selection example for clearer visualization _content/tour/concurrency/default-selection.go: add timestamps to default selection example for clearer visualization May 13, 2025
@gopherbot
Copy link
Contributor

Message from Murali Hemanna:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/671715.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Sean Liao:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/671715.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Sean Liao:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/671715.
After addressing review feedback, remember to publish your drafts!
@murali-kri5hna murali-kri5hna changed the title _content/tour/concurrency/default-selection.go: add timestamps to default selection example for clearer visualization _content/tour/concurrency: add timestamps to default selection example for clearer visualization May 14, 2025
@murali-kri5hna
Add timestamps to default selection example for clearer visualization
77eade7 
This change enhances the select/default example by displaying timestamps alongside the output. The timestamps help learners visualize: - The 50ms intervals of the default case - The 100ms intervals of the tick case - The immediate execution after tick events - The precise 500ms timing of the boom event Enhances readability and understanding of Go's concurrency timing behaviour. Fixes golang/tour#1733
@murali-kri5hna murali-kri5hna force-pushed the add-timestamp-in-default-selection branch from d53bb02 to 77eade7 Compare May 14, 2025 22:23
@gopherbot
Copy link
Contributor

This PR (HEAD: 77eade7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/671715.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Murali Hemanna:

Patch Set 4:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/671715.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Sean Liao:

Patch Set 6: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/671715.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-05-14T22:36:43Z","revision":"c342f75ce3968f9046ad98d4c188a45f0bd11229"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/671715.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Sean Liao:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/671715.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/671715.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/671715.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Michael Knyszek:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/671715.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

Message from Cherry Mui:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/671715.
After addressing review feedback, remember to publish your drafts!
gopherbot pushed a commit that referenced this pull request May 15, 2025
@murali-kri5hna @seankhliao
_content/tour/concurrency: add timestamps to default selection exampl…
29ad4af 
…e for clearer visualization The existing default selection example lacks clear timing visualization. This change displays timestamps alongside the output, helping learners visualize: - The 50ms intervals of the default case - The 100ms intervals of the tick case - The immediate execution after tick events - The precise 500ms timing of the boom event Enhances readability and understanding of Go's concurrency timing behavior. Fixes golang/tour#1733 Change-Id: I8aae3b5cac9197a36912a3235b15a29846347114 GitHub-Last-Rev: 77eade7 GitHub-Pull-Request: #320 Reviewed-on: https://go-review.googlesource.com/c/website/+/671715 Reviewed-by: Sean Liao <sean@liao.dev> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/671715 has been merged.
@gopherbot gopherbot closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@murali-kri5hna @gopherbot