Skip to content

Conversation

Lslightly
Copy link
Contributor

add missing ` in docs/contributing.md

@gopherbot
Copy link
Collaborator

This PR (HEAD: 1a21ede) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/656935.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Collaborator

Message from Jorropo:

Patch Set 1: Code-Review+2 Commit-Queue+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@Lslightly Lslightly changed the title docs/contribuing: add missing ` docs/contributing: add missing ` Mar 12, 2025
@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-12T09:06:00Z","revision":"a21dfdf543dd1bbe168bfee0411f35d73924d3f0"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/600b920f-4716-49f8-a20b-ca0e5147698f


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/600b920f-4716-49f8-a20b-ca0e5147698f


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Copied votes on follow-up patch sets have been updated:

  • LUCI-TryBot-Result-1 has been copied to patch set 2 (copy condition: "changekind:NO_CODE_CHANGE").

Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-12T09:21:21Z","revision":"6bfa453c7886d27dfdd082c84e9cb89b72302ac1"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1: kokoro-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/600b920f-4716-49f8-a20b-ca0e5147698f


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/bead4868-7122-4475-84f8-cd6e824a5163


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/bead4868-7122-4475-84f8-cd6e824a5163


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Jorropo:

Patch Set 2: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 2:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2: kokoro-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/bead4868-7122-4475-84f8-cd6e824a5163


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hongxiang Jiang:

Patch Set 2: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Madeline Kalil:

Patch Set 2: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/656935.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 13, 2025
add missing ` in docs/contributing.md Change-Id: Id19f59177c3ec6f428adaf0a38f56486bd8d0837 GitHub-Last-Rev: 1a21ede GitHub-Pull-Request: #3711 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/656935 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Hongxiang Jiang <hxjiang@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Madeline Kalil <mkalil@google.com> Reviewed-by: Jorropo <jorropo.pgm@gmail.com>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/656935 has been merged.

@gopherbot gopherbot closed this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants