Skip to content

dwtest: add test for go#72053 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

dwtest: add test for go#72053 #22

wants to merge 6 commits into from

Conversation

@derekparker
Copy link
Contributor

@derekparker derekparker commented Mar 12, 2025 •
edited
Loading

Adds a test for https://go.dev/issue/72053
Note the fix is submitted as https://go.dev/cl/656736

For golang/go#72053
@gopherbot
Copy link
Contributor

gopherbot commented Mar 12, 2025

This PR (HEAD: 74a97ae) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/debug/+/657355.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Mar 12, 2025

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 12, 2025

Message from Than McIntosh:

Patch Set 1: Code-Review+2 Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 12, 2025

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-12T22:00:47Z","revision":"6eda390a45ecc45937505959e5b2a2223eae8fa5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 12, 2025

Message from Than McIntosh:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 12, 2025

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 12, 2025

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 12, 2025

This PR (HEAD: ca6bced) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/debug/+/657355.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Mar 12, 2025

Message from Derek Parker:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 13, 2025

Message from Than McIntosh:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@derekparker
dwtest: add guard for go1.25, refactor and cleanup
6505dbd 
Adds guard for go1.25 which will have the associated fix. Also cleanup the test a bit, and limit the expected test string to amd64 which exhibited the issue.
@gopherbot
Copy link
Contributor

gopherbot commented Mar 13, 2025

This PR (HEAD: 6505dbd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/debug/+/657355.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Mar 13, 2025

Message from Derek Parker:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 13, 2025

Message from Derek Parker:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 13, 2025

Message from Derek Parker:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 13, 2025

Message from Heschi Kreinick:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 13, 2025

Message from Ian Lance Taylor:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 13, 2025

Message from Than McIntosh:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 13, 2025

Message from Ian Lance Taylor:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 13, 2025

Message from Than McIntosh:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 14, 2025

This PR (HEAD: ed0e868) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/debug/+/657355.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Mar 14, 2025

Message from Derek Parker:

Patch Set 6:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 14, 2025

This PR (HEAD: 6836341) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/debug/+/657355.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Mar 14, 2025

This PR (HEAD: dcd050f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/debug/+/657355.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Mar 14, 2025

Message from Ian Lance Taylor:

Patch Set 8: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 14, 2025

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-14T03:52:09Z","revision":"c49f70a9633aeca663d72147874a5e9c397dfcd3"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 14, 2025

Message from Ian Lance Taylor:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 14, 2025

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 14, 2025

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 14, 2025

Message from Ian Lance Taylor:

Patch Set 8: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 15, 2025

Message from David Chase:

Patch Set 8: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/657355.
After addressing review feedback, remember to publish your drafts!
gopherbot pushed a commit that referenced this pull request Mar 15, 2025
@derekparker @gopherbot
dwtest: add test for go#72053
70c1efa 
Adds a test for https://go.dev/issue/72053 Note the fix is submitted as https://go.dev/cl/656736 For [golang/go#72053](golang/go#72053) Change-Id: Iea247439f95cce85bf9a1560dd475be5048ec97a GitHub-Last-Rev: dcd050f GitHub-Pull-Request: #22 Reviewed-on: https://go-review.googlesource.com/c/debug/+/657355 Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Ian Lance Taylor <iant@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link
Contributor

gopherbot commented Mar 15, 2025

This PR is being closed because golang.org/cl/657355 has been merged.
@gopherbot gopherbot closed this Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@derekparker @gopherbot