fix: be tolerant to implicit submodules #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@ ## master #90 +/- ## ========================================== + Coverage 83.64% 83.68% +0.04% ========================================== Files 28 28 Lines 1785 1784 -1 ========================================== Hits 1493 1493 + Misses 177 176 -1 Partials 115 115 |
| https://github.com/gogs/git-module/releases/tag/v1.8.1 has been published for this merge. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Git itself allows adding another Git repository inside the current repository without properly defining as a submodule, so we need to be tolerant about that.
Link to the issue: gogs/gogs#6436
Checklist