fix: typo in struct AddOptions #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Re-open the PR to trigger the CI. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@ ## master #87 +/- ## ========================================== - Coverage 83.18% 82.85% -0.34% ========================================== Files 27 27 Lines 1737 1738 +1 ========================================== - Hits 1445 1440 -5 - Misses 179 185 +6 Partials 113 113 |
| FYI I'll publish a new version once #86 is also gotten merged. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #65
Describe the pull request
This fixes a typo in
AddOptions.Given this changes the public API, an alternative would be to deprecate
Pathsepcs, addPathspecs, and add a small shim. I'm happy to do that if y'all would rather :)Link to the issue: #65
Checklist